[Feat] DD Trace - Add instrumentation for streaming chunks #11338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds DataDog trace instrumentation for streaming chunks and updates tests to verify the new tracing behavior.
- Adds dd trace wrappers in the streaming generator (common_request_processing.py).
- Adds decorator-based dd tracing for completion endpoints (main.py).
- Updates tests and proxy configuration for new provider support and enhanced instrumentation.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_litellm/proxy/test_common_request_processing.py | New tests verifying dd trace wrapping for streaming responses. |
| litellm/proxy/proxy_config.yaml | Updated configuration to support the OpenAI model alongside anthropic. |
| litellm/proxy/common_request_processing.py | Implements dd trace instrumentation within the streaming generator. |
| litellm/model_prices_and_context_window_backup.json | Adds configuration for the embed-v4.0 model. |
| litellm/main.py | Applies dd trace decorators to streaming and synchronous completion functions. |
Comments suppressed due to low confidence (2)
tests/test_litellm/proxy/test_common_request_processing.py:291
- It appears that MagicMock is being used without an explicit import. Add 'from unittest.mock import MagicMock' to ensure the tests run correctly.
mock_tracer = MagicMock()
tests/test_litellm/proxy/test_common_request_processing.py:346
- It appears that MagicMock is being used without an explicit import in this test as well. Add 'from unittest.mock import MagicMock' to avoid NameError.
mock_tracer = MagicMock()
ishaan-jaff
added a commit
that referenced
this pull request
Jun 3, 2025
* fix: add tracing for litellm.completion * fix: NULL span add trace * fix: add tracing for litellm.completion streaming * fix: add tracing for litellm.completion streaming * fix: use a constant for str
stefan--
pushed a commit
to stefan--/litellm
that referenced
this pull request
Jun 12, 2025
…1338) * fix: add tracing for litellm.completion * fix: NULL span add trace * fix: add tracing for litellm.completion streaming * fix: add tracing for litellm.completion streaming * fix: use a constant for str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feat] DD Trace - Add instrumentation for streaming chunks
This PR adds DataDog trace instrumentation for streaming chunks and updates tests to verify the new tracing behavior.
After this PR
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
✅ Test
Changes